Completely remove OSGi Import-Package 'javax.annotation'#1708
Completely remove OSGi Import-Package 'javax.annotation'#1708HannesWell wants to merge 1 commit intogoogle:masterfrom
Conversation
This package is not required at runtime. Additionally update to latest maven-bundle-plugin 5.1.8. Signed-off-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thank you @sameb for the quick review and merge. |
|
Sure thing! Thanks for the PR! My hope is to finish merging outstanding pull requests this week and do a cursory sweep over open issues, fixing anything reasonable. The biggest barrier to a release is a resolution to #1383. At this point, I think we mostly need a Maven expert who can advise on how to structure the POMs to allow pushing an artifact with different deps and bytecode, so we can do a final 6.0 release as-is, and then a 7.0 release using the jakarta namespace as deps (despite the code still referencing javax). As soon as that's settled, I can cut a new release. |
|
Thanks for the elaboration. Looks like you already found a solution/plan. Looking forward to the new release! |
As suggested (and I assume also intended) in #1173 this PR changes the configuration of the maven-bundle-plugin to completely remove the import of the package
javax.annotation, which seems not to be required at runtime.With PR #1173 respectively #1697 the OSGi package import of
javax.annotation;version="[3.0,4)"was only changed tojavax.annotation, i.e. the version range was removed.@mcculls do you want to have a look at this?
Additionally update to latest maven-bundle-plugin 5.1.8.