Make PrivateModule#binder() non-final to allow binder customization in subclasses#1569
Closed
vlsi wants to merge 1 commit intogoogle:masterfrom
Closed
Make PrivateModule#binder() non-final to allow binder customization in subclasses#1569vlsi wants to merge 1 commit intogoogle:masterfrom
vlsi wants to merge 1 commit intogoogle:masterfrom
Conversation
…n subclasses One of the case for overriding #binder() would be calling Binder#skipSources(...) fixes google#1525
Contributor
Author
|
@ronshapiro , sorry for pinging you, however, would you please review and merge the change? It is kind of sad to wait one year for 1 line change 😭 |
Contributor
Author
|
@cpovirk , could you please review and merge the fix? In a nutshell, However, guice/core/src/com/google/inject/PrivateModule.java Lines 137 to 140 in c7a74a1 I believe that was just a typo, and there's no practical meaning for making I listed more details in the linked #1525 (comment) issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the cases for overriding
#binder()would be callingBinder#skipSources(...)fixes #1525