Update JpaPersistService to ignore subsequent calls to start() and stop()#1214
Closed
chrisparton1991 wants to merge 1 commit intogoogle:masterfrom
chrisparton1991:jpa-persist-service-multi-open-close
Closed
Update JpaPersistService to ignore subsequent calls to start() and stop()#1214chrisparton1991 wants to merge 1 commit intogoogle:masterfrom chrisparton1991:jpa-persist-service-multi-open-close
chrisparton1991 wants to merge 1 commit intogoogle:masterfrom
chrisparton1991:jpa-persist-service-multi-open-close
Conversation
…op(), which is consistent with the PersistService and UnitOfWork documentation.
maheshwarigagan
approved these changes
Oct 16, 2018
|
Thanks Chris ; I came here to fix the same problem... And saw you already did the job. I hope we'll get a release soon :) |
Contributor
Author
|
@jlannoy You're more than welcome, I hope we do too :) The PR got approved along with a few others recently, so we'll see what happens! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #947 and supersedes #972 and #598. It possibly also supersedes #1132, although I'm not sure what that user's use case is.
The current behaviour is to throw an
IllegalStateExceptionwhenJpaPersistService.start()orJpaPersistService.stop()are called multiple times. However, this clashes with the javadoc inPersistServiceandUnitOfWork, both of which state that subsequent calls to these methods are no-ops.JpaPersistService.end()already handles multiple calls, and has the following comment:// Let's not penalize users for calling end() multiple times.This PR brings
JpaPersistServiceand related tests into line with the documentation and resolves a pain point that multiple people (including myself) have experienced, e.g. https://stackoverflow.com/questions/17402081/how-to-start-jpa-in-a-guice-quartz-web-application.Thank you for taking the time to look at my PR.