Fix InternalProvisionExceptionTest, which was failing on Windows due to a newline assumption#1213
Closed
chrisparton1991 wants to merge 1 commit intogoogle:masterfrom
chrisparton1991:fix-test-failure
Closed
Fix InternalProvisionExceptionTest, which was failing on Windows due to a newline assumption#1213chrisparton1991 wants to merge 1 commit intogoogle:masterfrom chrisparton1991:fix-test-failure
chrisparton1991 wants to merge 1 commit intogoogle:masterfrom
chrisparton1991:fix-test-failure
Conversation
…to a newline assumption.
maheshwarigagan
approved these changes
Oct 16, 2018
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
…e system line separator and always using \n explicitly. (We were previously inconsistent: many places used \n, and many other places used %n with a formatter, which would end up being the system line separator.) This allows tests to pass on Windows, where the line separator is different. Also update tests to do a run with the windows line separator, to catch regressions. Fixes #1213. PiperOrigin-RevId: 525552063
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
…e system line separator and always using \n explicitly. (We were previously inconsistent: many places used \n, and many other places used %n with a formatter, which would end up being the system line separator.) This allows tests to pass on Windows, where the line separator is different. Also update tests to do a run with the windows line separator, to catch regressions. Fixes #1213. PiperOrigin-RevId: 525552063
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InternalProvisionExceptionuses the%nstring format, which returns a platform-specific newline code.InternalProvisionExceptionTest, however, assumes a\n, and therefore fails on Windows.I've updated the unit test to use
System.lineSeparator()so the test will pass on any platform.