feat!: Update '.prettierrc.json' to include trailingComma: "all" to match internal Google config#822
Merged
danielbankhead merged 6 commits intogoogle:mainfrom Oct 10, 2024
Merged
Conversation
Collaborator
|
Can we rebase this? Change looks good to me. |
Member
Author
|
I am not good at git, my brain has been permanently disfigured by fifteen years of using nothing but Piper/Perforce. I think I screwed this up somehow even though I was following a github help page. If you want to help me that's fine, or if you want to just make the change yourself that's fine too. I've spent half an hour on this and I'm quite frustrated. |
Member
Author
|
Ok I think I fixed it (thanks again for the help!) |
tonycoco
approved these changes
Mar 21, 2024
Collaborator
|
Note: the commit message needs to follow conventional commits. Can you amend your commit message? This change will be messy for lots of repos using |
Use value 'all' to match internal Google config
Member
Author
|
Done |
trailingComma: "all" to match internal Google config
No need to manually bump the version, a bot will create the release PR and handle versioning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #662