Support for Modbus, CIP and Ethernet/IP Industrial Protocols#758
Open
dreadl0ck wants to merge 13 commits intogoogle:masterfrom
Open
Support for Modbus, CIP and Ethernet/IP Industrial Protocols#758dreadl0ck wants to merge 13 commits intogoogle:masterfrom
dreadl0ck wants to merge 13 commits intogoogle:masterfrom
Conversation
|
hey there. This could be a valuable addition to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains a port of @traetox efforts on bringing Modbus, CIP and EtherIP to gopacket.
The original pull request can be found here: #408
Almost two years have passed since the original pull request, but unfortunately it still didn't get merged into master because not all authors manage to sign the Google CLA.
Because I needed parsing support for those protocols for a research project,
I've reimplemented their changes in my fork of gopacket.
Thanks @traetox for publishing their implementation!
cc @notti