pcapgo: add read/write support for Decryption Secrets Block (DSB). #1042
Open
cfc4n wants to merge 2 commits intogoogle:masterfrom
Open
pcapgo: add read/write support for Decryption Secrets Block (DSB). #1042cfc4n wants to merge 2 commits intogoogle:masterfrom
cfc4n wants to merge 2 commits intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
A Decryption Secrets Block (DSB) stores (session) secrets that enable decryption of packets within the capture file. see https://github.com/pcapng/pcapng/blob/master/draft-tuexen-opsawg-pcapng.md for more info. Signed-off-by: CFC4N <cfc4n.cs@gmail.com>
|
LGTM. We need this as well. @gconnell Any chance to get this merged? |
stv0g
reviewed
Aug 18, 2022
|
hey there. feel free to move this to the new fork (gopacket/gopacket) and I'll take a look at it. |
|
@mosajjal I create another PR in the fork. Could you briefly elaborate why there is a fork? Or why there is a need for one? |
|
Nevermind, I found #1016 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support reading and writing pcapng files with DSBs.
the same as https//github.com/wireshark/wireshark
The TLS dissector will be updated in the future to make use of these secrets.
pcapng spec update: IETF-OPSAWG-WG/draft-ietf-opsawg-pcap#54
DSB block format:
Use Case:
gojue/ecapture#153