Open
Conversation
Not all compilers on linux add it implicitly. It won't do any harm on those which do. Closes google#3878
ProKashif
approved these changes
Aug 6, 2022
|
Hi, |
Author
|
This is just waiting for someone with permission to actually review and (hopefully) merge it (the test failures shown in the checks output were present on master as well at the time they ran). Our team has been using this branch for a long time now. |
|
Hi, I think that Bazel 6 allows to do a selection depending on the compiler (gcc or clang), see Maybe |
Author
|
Yes I think that would require bazel 6. And even after it's been released, it'll be a while before bazel 6 can be assumed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all compilers on linux add it implicitly.
It won't do any harm on those which do.
Closes #3878