-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Comparing changes
Open a pull request
base repository: google/googletest
base: adeef192947f
head repository: google/googletest
compare: 1e315c5b1a62
- 17 commits
- 7 files changed
- 5 contributors
Commits on Jun 13, 2020
-
Avoid using environ on FreeBSD
WebKit passes -Wl,--no-undefined to the compiler when linking shared libraries. This is usually a good practice, but it causes gtest to fail to link because of the use of environ. FreeBSD puts environ symbol in crt1.o instead of libc.so, so the linker is unable to find environ when linking a shared library. Fortunately, there is an easy way to fix it. Since the only use of environ in gtest is to pass it to execve, we can simply replace execve with execv to avoid the need of environ. execv is usually a simple wrapper around execve, so it should be safe to use. This problem was found and reported more than three years ago. The same fix is already committed to WebKit and we don't see any problem reports caused by the change. https://bugs.webkit.org/show_bug.cgi?id=138420 https://trac.webkit.org/changeset/194501/webkit https://bugs.webkit.org/show_bug.cgi?id=208409 https://trac.webkit.org/changeset/257691/webkit https://groups.google.com/forum/#!topic/googletestframework/wrrMj_fmXMc
Configuration menu - View commit details
-
Copy full SHA for 2e8ebe6 - Browse repository at this point
Copy the full SHA 2e8ebe6View commit details
Commits on Aug 3, 2020
-
Add matchers for testing exception properties
This PR adds matchers that accept a callable and verify that when invoked, it throws an exception with the given type and properties. Fixes #952
Vladimir Goncharov committedAug 3, 2020 Configuration menu - View commit details
-
Copy full SHA for 9ac4cd0 - Browse repository at this point
Copy the full SHA 9ac4cd0View commit details -
Small improvements: code style and property name
Vladimir Goncharov committedAug 3, 2020 Configuration menu - View commit details
-
Copy full SHA for 46734d9 - Browse repository at this point
Copy the full SHA 46734d9View commit details -
Add missing documentation piece
Vladimir Goncharov committedAug 3, 2020 Configuration menu - View commit details
-
Copy full SHA for 49d1201 - Browse repository at this point
Copy the full SHA 49d1201View commit details -
Add a test for duplicate catch clauses in throw matchers, fix a coupl…
…e of nitpicks.
Vladimir Goncharov committedAug 3, 2020 Configuration menu - View commit details
-
Copy full SHA for 69c510f - Browse repository at this point
Copy the full SHA 69c510fView commit details -
Add a test to ensure that the
Throwsmatcher only invokes its argum……ent once.
Vladimir Goncharov committedAug 3, 2020 Configuration menu - View commit details
-
Copy full SHA for 92d0a6f - Browse repository at this point
Copy the full SHA 92d0a6fView commit details -
Vladimir Goncharov committed
Aug 3, 2020 Configuration menu - View commit details
-
Copy full SHA for 0a80845 - Browse repository at this point
Copy the full SHA 0a80845View commit details -
Update tests after changing an error message
Vladimir Goncharov committedAug 3, 2020 Configuration menu - View commit details
-
Copy full SHA for c46bdea - Browse repository at this point
Copy the full SHA c46bdeaView commit details -
Vladimir Goncharov committed
Aug 3, 2020 Configuration menu - View commit details
-
Copy full SHA for 4ebbfea - Browse repository at this point
Copy the full SHA 4ebbfeaView commit details -
Cleanup a bulky expression, document implementation details
Vladimir Goncharov committedAug 3, 2020 Configuration menu - View commit details
-
Copy full SHA for a899cec - Browse repository at this point
Copy the full SHA a899cecView commit details -
Remove ThrowsMessageHasSubstr and fix some nits after review
Vladimir Goncharov committedAug 3, 2020 Configuration menu - View commit details
-
Copy full SHA for 7f1c8bb - Browse repository at this point
Copy the full SHA 7f1c8bbView commit details
Commits on Aug 12, 2020
-
This makes it easier to include the license in redistributions, as required by the license.
Rob Earhart authoredAug 12, 2020 Configuration menu - View commit details
-
Copy full SHA for 025e1a4 - Browse repository at this point
Copy the full SHA 025e1a4View commit details
Commits on Aug 24, 2020
-
Fix DoAll to work with move-only sink arguments. This changes types of the first n - 1 actions so that they only get a readonly view of the arguments. The last action will accept move only objects. PiperOrigin-RevId: 327031893
Configuration menu - View commit details
-
Copy full SHA for fc1e778 - Browse repository at this point
Copy the full SHA fc1e778View commit details -
Merge pull request #2904 from AmatanHead:throw-matchers
PiperOrigin-RevId: 327294137
Configuration menu - View commit details
-
Copy full SHA for aa4cbcd - Browse repository at this point
Copy the full SHA aa4cbcdView commit details -
Merge pull request #2984 from earhart:master
PiperOrigin-RevId: 327324992
Configuration menu - View commit details
-
Copy full SHA for 655bff5 - Browse repository at this point
Copy the full SHA 655bff5View commit details -
Workaround static assert in early versions libc++ The error is "Attempted to construct a reference element in a tuple with an rvalue". We can fix this by putting everything into a non temporary tuple_args and implitly convert to the other tuple types. This avoids binding an rvalue reference to an lvalue reference inside the tuple. PiperOrigin-RevId: 327624990
Configuration menu - View commit details
-
Copy full SHA for ec9be15 - Browse repository at this point
Copy the full SHA ec9be15View commit details -
Merge pull request #2895 from lantw44:wip/lantw/Avoid-using-environ-o…
…n-FreeBSD PiperOrigin-RevId: 327799934
Configuration menu - View commit details
-
Copy full SHA for 1e315c5 - Browse repository at this point
Copy the full SHA 1e315c5View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff adeef192947f...1e315c5b1a62