Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/googletest
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: adeef192947f
Choose a base ref
...
head repository: google/googletest
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1e315c5b1a62
Choose a head ref
  • 17 commits
  • 7 files changed
  • 5 contributors

Commits on Jun 13, 2020

  1. Avoid using environ on FreeBSD

    WebKit passes -Wl,--no-undefined to the compiler when linking shared
    libraries. This is usually a good practice, but it causes gtest to fail
    to link because of the use of environ. FreeBSD puts environ symbol in
    crt1.o instead of libc.so, so the linker is unable to find environ when
    linking a shared library.
    
    Fortunately, there is an easy way to fix it. Since the only use of
    environ in gtest is to pass it to execve, we can simply replace execve
    with execv to avoid the need of environ. execv is usually a simple
    wrapper around execve, so it should be safe to use.
    
    This problem was found and reported more than three years ago. The same
    fix is already committed to WebKit and we don't see any problem reports
    caused by the change.
    
    https://bugs.webkit.org/show_bug.cgi?id=138420
    https://trac.webkit.org/changeset/194501/webkit
    https://bugs.webkit.org/show_bug.cgi?id=208409
    https://trac.webkit.org/changeset/257691/webkit
    https://groups.google.com/forum/#!topic/googletestframework/wrrMj_fmXMc
    lantw44 committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    2e8ebe6 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2020

  1. Add matchers for testing exception properties

    This PR adds matchers that accept a callable and verify that when invoked, it throws an exception with the given type and properties.
    
    Fixes #952
    Vladimir Goncharov committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    9ac4cd0 View commit details
    Browse the repository at this point in the history
  2. Small improvements: code style and property name

    Vladimir Goncharov committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    46734d9 View commit details
    Browse the repository at this point in the history
  3. Add missing documentation piece

    Vladimir Goncharov committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    49d1201 View commit details
    Browse the repository at this point in the history
  4. Add a test for duplicate catch clauses in throw matchers, fix a coupl…

    …e of nitpicks.
    Vladimir Goncharov committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    69c510f View commit details
    Browse the repository at this point in the history
  5. Add a test to ensure that the Throws matcher only invokes its argum…

    …ent once.
    Vladimir Goncharov committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    92d0a6f View commit details
    Browse the repository at this point in the history
  6. Fix build under msvc

    Vladimir Goncharov committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    0a80845 View commit details
    Browse the repository at this point in the history
  7. Update tests after changing an error message

    Vladimir Goncharov committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    c46bdea View commit details
    Browse the repository at this point in the history
  8. Fix build under msvc

    Vladimir Goncharov committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    4ebbfea View commit details
    Browse the repository at this point in the history
  9. Cleanup a bulky expression, document implementation details

    Vladimir Goncharov committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    a899cec View commit details
    Browse the repository at this point in the history
  10. Remove ThrowsMessageHasSubstr and fix some nits after review

    Vladimir Goncharov committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    7f1c8bb View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. Export LICENSE

    This makes it easier to include the license in redistributions, as required by the license.
    Rob Earhart authored Aug 12, 2020
    Configuration menu
    Copy the full SHA
    025e1a4 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2020

  1. Googletest export

    Fix DoAll to work with move-only sink arguments.
    
    This changes types of the first n - 1 actions so that they only get a readonly
    view of the arguments. The last action will accept move only objects.
    
    PiperOrigin-RevId: 327031893
    Abseil Team authored and vslashg committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    fc1e778 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2904 from AmatanHead:throw-matchers

    PiperOrigin-RevId: 327294137
    vslashg committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    aa4cbcd View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2984 from earhart:master

    PiperOrigin-RevId: 327324992
    vslashg committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    655bff5 View commit details
    Browse the repository at this point in the history
  4. Googletest export

    Workaround static assert in early versions libc++
    
    The error is "Attempted to construct a reference element in a tuple with an
    rvalue". We can fix this by putting everything into a non temporary tuple_args
    and implitly convert to the other tuple types. This avoids binding an rvalue
    reference to an lvalue reference inside the tuple.
    
    PiperOrigin-RevId: 327624990
    Abseil Team authored and vslashg committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    ec9be15 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #2895 from lantw44:wip/lantw/Avoid-using-environ-o…

    …n-FreeBSD
    
    PiperOrigin-RevId: 327799934
    vslashg committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    1e315c5 View commit details
    Browse the repository at this point in the history
Loading