Avoid duplicate output and print all forbidden licenses by lavrd · Pull Request #60 · google/go-licenses

lavrd · 2021-04-07T08:36:09Z

First update

I added following lines to avoid duplicate output on error:

rootCmd.SilenceErrors = true // to avoid duplicate error output
rootCmd.SilenceUsage = true  // to avoid usage/help output on error

For example, we have two folders (./test1, test2) with GNU AGPLv3 license.
When I execute following command:

go run . check ./test

And ./test folder is not exists, we have following output:

Error: errors for ["./test"]:
./test: -: stat /Users/lavr/dev/github/go-licenses/test: directory not found
Usage:
  licenses check <package> [flags]

Flags:
  -h, --help   help for check

Global Flags:
      --alsologtostderr                  log to standard error as well as files
      --confidence_threshold float       Minimum confidence required in order to positively identify a license. (default 0.9)
      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
      --log_dir string                   If non-empty, write log files in this directory
      --logtostderr                      log to standard error instead of files
      --stderrthreshold severity         logs at or above this threshold go to stderr (default 2)
  -v, --v Level                          log level for V logs
      --vmodule moduleSpec               comma-separated list of pattern=N settings for file-filtered logging

F0407 11:24:23.832579    7607 main.go:45] errors for ["./test"]:
./test: -: stat /Users/lavr/dev/github/go-licenses/test: directory not found
exit status 1

So, in this output we have error, then usage output, and error again. The first error message and usage output looks unnecessary.
But with my update output will be:

F0407 11:27:19.847123    7648 main.go:45] errors for ["./test"]:
./test: -: stat /Users/lavr/dev/github/go-licenses/test: directory not found
exit status 1

And it is look nicer.

Second update

I added a code to print all forbidden license before program exit. I think it will be more convenient to check for all forbidden licenses.

For example, we have two folders (./test1, test2) with GNU AGPLv3 license.

Output without updates:

$ go run . check ./test1 ./test2
Forbidden license type AGPL-3.0 for library github.com/google/go-licenses/test1
exit status 1

Output with updates:

$ go run . check ./test1 ./test2
Forbidden license type AGPL-3.0 for library github.com/google/go-licenses/test1
Forbidden license type AGPL-3.0 for library github.com/google/go-licenses/test2
exit status 1

…en licenses before exit

google-cla · 2021-04-07T08:36:14Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

lavrd · 2021-04-07T08:39:52Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).

The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.

The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

Bobgy

Thanks! These are neat improvements!

Added flags to avoid duplicate output on errors and print all forbidd…

c5ca5a3

…en licenses before exit

google-cla bot added the cla: no Contributor license agreement not signed (https://cla.developers.google.com) label Apr 7, 2021

google-cla bot added cla: yes Contributor license agreement signed (https://cla.developers.google.com) and removed cla: no Contributor license agreement not signed (https://cla.developers.google.com) labels Apr 7, 2021

Merge branch 'master' into master

1835bb5

Bobgy approved these changes May 20, 2022

View reviewed changes

Bobgy merged commit e69cf6e into google:master May 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid duplicate output and print all forbidden licenses#60

Avoid duplicate output and print all forbidden licenses#60
Bobgy merged 2 commits intogoogle:masterfrom
lavrd:master

lavrd commented Apr 7, 2021

Uh oh!

google-cla bot commented Apr 7, 2021

Uh oh!

lavrd commented Apr 7, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

Bobgy left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

lavrd commented Apr 7, 2021

First update

Second update

Uh oh!

google-cla bot commented Apr 7, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

lavrd commented Apr 7, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

Bobgy left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants