Check: return non-zero status code for unknown licenses.#44
Closed
wlynch wants to merge 2 commits intogoogle:masterfrom
Closed
Check: return non-zero status code for unknown licenses.#44wlynch wants to merge 2 commits intogoogle:masterfrom
wlynch wants to merge 2 commits intogoogle:masterfrom
Conversation
Previously if an unknown license was detected, an error message was printed, but the command would still return 0, indicating success for many CI tools. This fixes the behavior to return a proper non-zero error code. Fixes google#31.
|
Tested this, and it seems to work ok. Makes #46 even more necessary, or else your project will fail if you don't have license files for all your 1st-party packages (e.g in closed-source projects) |
NatalieDoduc
approved these changes
Jun 24, 2021
Merged
Collaborator
|
Superceded by #150 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if an unknown license was detected, an error message was
printed, but the command would still return 0, indicating success for
many CI tools.
This fixes the behavior to return a proper non-zero error code.
Fixes #31.