chore: update golang.org/x/tools to v0.36.0 to resolve the build error#334
Merged
Bobgy merged 4 commits intogoogle:masterfrom Sep 8, 2025
Merged
Conversation
Collaborator
|
Can you fix the build failure? It seems it doesn't want go 1.23.0 format. Maybe we need to upgrade the github actions env to higher go versions first / at the same PR. |
Contributor
Author
|
I tested this pull request in the following pull request and confirmed CI passed. If we upgrade golangci-lint to the latest version, we need to fix code. https://github.com/suzuki-shunsuke/go-licenses/actions/runs/17544642696/job/49823170134 DetailsSo I gave up the latest version and updated to v1.64.8 |
Bobgy
approved these changes
Sep 8, 2025
``` Error: invalid version string 'v1.64.8', golangci-lint v1 is not supported by golangci-lint-action >= v7. ```
f92485d to
c12c97a
Compare
Collaborator
|
Thanks for the fix! I'm going to release another v2 version with the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #333
I've confirmed the build succeeded.
go install .