Skip to content

add report subcommand with custom templates#141

Merged
Bobgy merged 1 commit intogoogle:masterfrom
willnorris:template
Aug 25, 2022
Merged

add report subcommand with custom templates#141
Bobgy merged 1 commit intogoogle:masterfrom
willnorris:template

Conversation

@willnorris
Copy link
Copy Markdown
Contributor

Fixes #140

@Bobgy
Copy link
Copy Markdown
Collaborator

Bobgy commented Aug 24, 2022

Thank you for the great contribution!

Left some initial thoughts for discussion.

@willnorris
Copy link
Copy Markdown
Contributor Author

Left some initial thoughts for discussion.

I'm not seeing them. Did they miss getting submitted?

@Bobgy
Copy link
Copy Markdown
Collaborator

Bobgy commented Aug 24, 2022

Ohhh, forgot to send pending comments

@willnorris willnorris force-pushed the template branch 2 times, most recently from d28fcac to 31236a8 Compare August 24, 2022 18:17
The new report subcommand replaces the existing csv command (and the csv
command is now deprecated). By default `go-licenses report` will output
CSV, but it also allows for a custom go template to be used.
@willnorris
Copy link
Copy Markdown
Contributor Author

okay, please take a look. There is now a report subcommand that defaults to CSV output, and allows for a custom template to be specified. The csv subcommand still exists (and simply calls into the new report command), but is documented as deprecated.

@willnorris willnorris changed the title add template subcommand for custom reports add report subcommand with custom templates Aug 24, 2022
Copy link
Copy Markdown
Collaborator

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍 looks great!

@Bobgy Bobgy merged commit 5eedde1 into google:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: allow for custom reports

2 participants