Skip to content

feat!: Improve support for custom property defaults #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gmlewis merged 4 commits into from
Jan 14, 2026
Merged

feat!: Improve support for custom property defaults #3906

gmlewis merged 4 commits into from
Jan 14, 2026
+310 −36

Conversation

@stevehipwell
Copy link
Contributor

@stevehipwell stevehipwell commented Jan 8, 2026 •
edited by gmlewis
Loading

BREAKING CHANGE: CustomProperty.DefaultValue is now type any and .ValueType is now type PropertyValueType.

Closes #3692

@stevehipwell stevehipwell mentioned this pull request Jan 8, 2026
Closed
@stevehipwell stevehipwell force-pushed the custom-property-default branch from 1db98bf to 3adae47 Compare January 8, 2026 17:56
@stevehipwell stevehipwell force-pushed the custom-property-default branch from 3adae47 to 3e0f027 Compare January 13, 2026 12:28
@stevehipwell stevehipwell marked this pull request as ready for review January 13, 2026 12:28
@stevehipwell
Copy link
Contributor Author

stevehipwell commented Jan 13, 2026

@gmlewis this should be ready for review now.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jan 13, 2026
@codecov
Copy link

codecov bot commented Jan 13, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.45%. Comparing base (a427207) to head (a3d6f79).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3906      +/-   ##
==========================================
+ Coverage   92.44%   92.45%   +0.01%     
==========================================
  Files         203      203              
  Lines       14927    14954      +27     
==========================================
+ Hits        13799    13826      +27     
  Misses        926      926              
  Partials      202      202

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gmlewis
gmlewis requested changes Jan 13, 2026
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stevehipwell!
Please add unit tests that exercise each path in each of the newly-added helpers.

@gmlewis gmlewis changed the title feat: Improve support for custom property defaults feat!: Improve support for custom property defaults Jan 13, 2026
@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Jan 13, 2026
@stevehipwell
Copy link
Contributor Author

stevehipwell commented Jan 13, 2026

@gmlewis sorry for the oversight, I checked my notes which said fix tests and I just assumed it was just the failing ones. Will add tests ASAP.

@stevehipwell
Copy link
Contributor Author

stevehipwell commented Jan 13, 2026

@gmlewis I've pushed up the tests.

gmlewis
gmlewis approved these changes Jan 13, 2026
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stevehipwell!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @alexandear - @zyfy29

alexandear
alexandear approved these changes Jan 13, 2026
View reviewed changes
@stevehipwell
Copy link
Contributor Author

stevehipwell commented Jan 14, 2026

Thanks for spotting the typos @alexandear. @gmlewis I think this should be good to go now.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jan 14, 2026
@gmlewis
Copy link
Collaborator

gmlewis commented Jan 14, 2026

Thank you, @stevehipwell and @alexandear!
Merging.

@gmlewis gmlewis merged commit 5458fbc into google:master Jan 14, 2026
8 checks passed
@stevehipwell stevehipwell deleted the custom-property-default branch January 14, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

+1 more reviewer

@alexandear alexandear alexandear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The DefaultValue of a CustomProperty is incorrect type

3 participants

@stevehipwell @gmlewis @alexandear