-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Add support for Enterprise Team Members APIs #3873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3873 +/- ##
==========================================
+ Coverage 92.40% 92.43% +0.03%
==========================================
Files 200 200
Lines 14382 14472 +90
==========================================
+ Hits 13289 13377 +88
- Misses 894 895 +1
- Partials 199 200 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Not-Dhananjay-Mishra!
Just a few minor tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
|
@gmlewis Thanks for the suggestions, I have fixed them. |
stevehipwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thank you, @stevehipwell! |
Related: #3860
This PR adds support for Enterprise Team Members
/enterprises/{enterprise}/teams/{enterprise-team}/memberships/enterprises/{enterprise}/teams/{enterprise-team}/memberships/add/enterprises/{enterprise}/teams/{enterprise-team}/memberships/remove/enterprises/{enterprise}/teams/{enterprise-team}/memberships/{username}/enterprises/{enterprise}/teams/{enterprise-team}/memberships/{username}/enterprises/{enterprise}/teams/{enterprise-team}/memberships/{username}