feat: Add JSON marshal tests for dependabot alerts#3480
feat: Add JSON marshal tests for dependabot alerts#3480gmlewis merged 2 commits intogoogle:masterfrom
Conversation
d41dbb8 to
db419fa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3480 +/- ##
=======================================
Coverage 91.02% 91.02%
=======================================
Files 179 179
Lines 15561 15561
=======================================
Hits 14165 14165
Misses 1223 1223
Partials 173 173 ☔ View full report in Codecov by Sentry. |
There are several possibilities, and I would have to look up those specific cases to answer your question but don't have time at the moment. We rarely remove fields but do try to mark them as deprecated if indeed they are. Most of the time, they are added by GitHub after our endpoints are written. When someone needs them, we add a PR. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @raisa2010.
LGTM.
Merging.
|
Got it, thank you for clarifying and reviewing @gmlewis! |
This PR adds some more tests for issue #55. Would appreciate a review!
Also noticed that some fields in the Github API response such as
cvss_severitiesandepssare not supported in the existing struct. Is this expected (deprecated fields) or just new fields in the Github response that haven't been reflected in the current codebase yet?Thanks in advance!