Add deprecation messages to security managers APIs#3426
Merged
gmlewis merged 1 commit intogoogle:masterfrom Jan 7, 2025
just-joshing:master
Merged
Add deprecation messages to security managers APIs#3426gmlewis merged 1 commit intogoogle:masterfrom just-joshing:master
gmlewis merged 1 commit intogoogle:masterfrom
just-joshing:master
Conversation
Contributor
Author
|
I had previously tried updating these operations instead to use the replacement client methods under-the-hood but got feedback to go the deprecation route instead. |
gmlewis
approved these changes
Jan 7, 2025
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @just-joshing and @stevehipwell !
LGTM.
Merging.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3426 +/- ##
==========================================
- Coverage 97.72% 92.22% -5.51%
==========================================
Files 153 173 +20
Lines 13390 14937 +1547
==========================================
+ Hits 13085 13775 +690
- Misses 215 1068 +853
- Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The organization security manager role REST APIs are being sunset (https://gh.io/security-managers-rest-api-sunset) in favor of the organization roles REST APIs.
This change adds deprecation messages to tell consumers which client operations to use instead going forward.