feat: Add custom_property events#3379
Conversation
custom_property and custom_property_values events are added. Closes google#3207
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3379 +/- ##
==========================================
- Coverage 97.72% 92.30% -5.42%
==========================================
Files 153 176 +23
Lines 13390 15031 +1641
==========================================
+ Hits 13085 13874 +789
- Misses 215 1064 +849
- Partials 90 93 +3 ☔ View full report in Codecov by Sentry. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @acouvreur!
One minor tweak, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Done! |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @acouvreur !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
|
Thank you, @stevehipwell ! |
custom_property and custom_property_values events are added.
Closes #3207
script/fmt.shscript/test.shscript/lint.shscript/generate.shbecause changes were detected