chore: Deprecate legacy ID-based team methods#3373
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3373 +/- ##
==========================================
- Coverage 97.72% 92.30% -5.42%
==========================================
Files 153 176 +23
Lines 13390 15031 +1641
==========================================
+ Hits 13085 13874 +789
- Misses 215 1064 +849
- Partials 90 93 +3 ☔ View full report in Codecov by Sentry. |
|
@gmlewis the metadata generation doesn't look right. I manually updated all of the metadata (before I knew about the script) to fix the incorrect docs and URL templates for the legacy API calls but generate is putting them back. Just a nit but is there a reason why |
Yes, that is an indication to the reader and the tools that this comment is used by the tooling. |
|
@gmlewis but what about the issue with linking to the incorrect docs? https://github.com/google/go-github/blob/master/github/teams.go#L107...L112 |
The links are managed by the official GitHub OpenAPI specification, and it periodically needs to be updated (which was last done here: #3352 ). I have not done a deep dive into this issue yet, but it may need updating again to fix the issue. |
|
I've gone ahead and created #3374. I'm not sure if that will help your PR yet or not. |
|
Once it is merged, you can update your local |
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
155894b to
ff412f6
Compare
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @stevehipwell !
LGTM.
Merging.
Resolves #3368
This PR makes all legacy ID based team methods as deprecated based on the closing down notice.