Add support in rulesets for including or excluding repos based on properties#3194
Merged
gmlewis merged 7 commits intogoogle:masterfrom Jun 26, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3194 +/- ##
==========================================
- Coverage 97.72% 92.90% -4.82%
==========================================
Files 153 171 +18
Lines 13390 11548 -1842
==========================================
- Hits 13085 10729 -2356
- Misses 215 726 +511
- Partials 90 93 +3 ☔ View full report in Codecov by Sentry. |
gmlewis
approved these changes
Jun 25, 2024
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @claystation !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Contributor
Author
|
@gmlewis i had to fix a small bug by removing |
Collaborator
|
Thank you, @ysoldak and @claystation ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github recently introduced Repository Properties. Rulesets can include or exclude repositories based on these properties.
The PR implements those conditions.
According to Github API docs:
https://docs.github.com/en/rest/orgs/rules?apiVersion=2022-11-28#create-an-organization-repository-ruleset
Changed comment on
RulesetConditionsstruct to say either use Name, ID OR repo property. The docs have not been super clear on this but i assume so because when creating rulesets trough UI you can either select repositories based on name or on property.Please let me know what you think!