Support status codes 302 and 200 in GetArchiveLink endpoint#3172
Support status codes 302 and 200 in GetArchiveLink endpoint#3172gmlewis merged 1 commit intogoogle:masterfrom assembly-winston:fixForHTTPCodeOnGetLink
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @assembly-winston !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Also awaiting signed CLA before proceeding.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3172 +/- ##
==========================================
- Coverage 97.72% 92.93% -4.79%
==========================================
Files 153 171 +18
Lines 13390 11542 -1848
==========================================
- Hits 13085 10727 -2358
- Misses 215 724 +509
- Partials 90 91 +1 ☔ View full report in Codecov by Sentry. |
|
Signed CLA! |
|
OK, I'm going to override the normal policy of a second LGTM for this simple change (similar to adding a field to a struct) and go ahead and merge. |
Fixes: #3171