Skip to content

Add Topics to EditChange struct#3057

Merged
gmlewis merged 3 commits intogoogle:masterfrom
riaje:webhook-repository-add-changes-topics
Jan 24, 2024
Merged

Add Topics to EditChange struct#3057
gmlewis merged 3 commits intogoogle:masterfrom
riaje:webhook-repository-add-changes-topics

Conversation

@riaje
Copy link
Copy Markdown
Contributor

@riaje riaje commented Jan 24, 2024

Fixes: #3056

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b61795d) 97.71% compared to head (fbb0520) 97.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3057   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files         152      152           
  Lines       13326    13326           
=======================================
  Hits        13021    13021           
  Misses        215      215           
  Partials       90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @riaje !
Just one minor tweak, please, then we should be ready to merge.

Fix slice without pointer because it's already a reference type

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@riaje
Copy link
Copy Markdown
Contributor Author

riaje commented Jan 24, 2024

I will fix the tests, sorry I have made my commit a bit too faster

Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @riaje !
LGTM.
Merging after tests pass.

@gmlewis gmlewis merged commit 20fc901 into google:master Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Topics to EditChange struct

2 participants