Add support for "performed_via_github_app" and "requested_team" in IssueEvent#2946
Merged
gmlewis merged 3 commits intogoogle:masterfrom Oct 3, 2023
Merged
Add support for "performed_via_github_app" and "requested_team" in IssueEvent#2946gmlewis merged 3 commits intogoogle:masterfrom
gmlewis merged 3 commits intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
@@ Coverage Diff @@
## master #2946 +/- ##
=======================================
Coverage 98.19% 98.19%
=======================================
Files 145 145
Lines 12720 12720
=======================================
Hits 12490 12490
Misses 156 156
Partials 74 74
|
WillAbides
approved these changes
Oct 3, 2023
Collaborator
|
Thank you, @WillAbides ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Source
#2945 mentions the reasoning for this PR.
Why
"performed_via_github_app"and"requested_team"are valuable results in the issue events response (when available) to determine more about the event. It also keeps the struct up to date with the API response.What
Other notes
Ran all available test scripts, updated accordingly. Tests passing.