Fix repo rules bypass settings#2831
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2831 +/- ##
==========================================
- Coverage 98.06% 98.06% -0.01%
==========================================
Files 137 137
Lines 12289 12287 -2
==========================================
- Hits 12051 12049 -2
Misses 162 162
Partials 76 76
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you @o-sama !
LGTM.
@liaodaniel - could you please look at these breaking API changes since you are the original author of this section of code and make sure you are happy with them?
|
It seems the breaking change was introduced by GitHub (point 2 here): https://github.blog/changelog/2023-06-27-repository-rules-public-beta-updates/ The latest change in master added a couple of test cases related to organization rulesets which used |
Yep, this looks good from my end. Part of me felt that I probably should have waited a bit until the feature was out of beta before introducing it but the feature seemed too compelling to wait 😄 |
|
Thank you, @liaodaniel ! |
This PR reconciles library with GitHub API for the following regarding repo rulesets:
BypassModeshould be part ofBypassActor.ActorTypepossible values documentation updated to match API docs.RulesetID field changed toInt64pointer and addedomitemptyto allow for nil, ruleset ID is unknown prior to creation and is not required when sending a POST request to create ruleset.