Add support for personal_access_token_request webhook event type#2826
Add support for personal_access_token_request webhook event type#2826gmlewis merged 3 commits intogoogle:masterfrom
personal_access_token_request webhook event type#2826Conversation
personal_access_token_request webhook event typepersonal_access_token_request webhook event type
Codecov Report
@@ Coverage Diff @@
## master #2826 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 136 136
Lines 12279 12281 +2
=======================================
+ Hits 12041 12043 +2
Misses 162 162
Partials 76 76
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @joaopenteado !
Just a few tweaks please, then we will be ready for a second LGTM+Approval from any other contributor to this repo before merging.
|
Thanks for the very quick response, @gmlewis! |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @joaopenteado !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
|
@gmlewis upon further testing, I've actually found that this webhook delivers an map of permissions in the API. This isn't very well documented IMO but could be inferred I guess. I've updated the event type to fix this. Here's an excerpt from a webhook event I received from GitHub during integration testing: {
"action": "created",
"personal_access_token_request": {
"id": 11233,
"owner": { /* ... */ },
"repository_selection": "all",
"repository_count": null,
"repositories": null,
"permissions_added": {
"organization": {
"organization_announcement_banners": "write",
"organization_events": "read"
},
"repository": {
"codespaces_lifecycle_admin": "read",
"metadata": "read",
"security_events": "write"
}
},
"permissions_upgraded": {},
"permissions_result": {
"organization": {
"organization_announcement_banners": "write",
"organization_events": "read"
},
"repository": {
"codespaces_lifecycle_admin": "read",
"metadata": "read",
"security_events": "write"
}
},
"created_at": "2023-07-07T00:37:57+09:00",
"token_expired": false,
"token_expires_at": "2023-08-05T15:37:56Z",
"token_last_used_at": null
},
"organization": { /* ... */ },
"sender": { /* ... */},
"installation": {
"id": 1111111,
"node_id": "xxxxxxxxxxxxxx"
} |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @joaopenteado !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
|
Thank you, @liaodaniel ! |
This PR adds support for the
personal_access_token_requestwebhook event.