Add Runner to generate-jitconfig method#2818
Merged
gmlewis merged 2 commits intogoogle:masterfrom Jun 23, 2023
Merged
Conversation
gmlewis
reviewed
Jun 23, 2023
52d68fd to
88736b1
Compare
88736b1 to
14f1b37
Compare
Collaborator
|
Please run |
Contributor
Author
|
Hi @gmlewis apologize, I thought it was not reviewed yet. I have run |
gmlewis
approved these changes
Jun 23, 2023
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
No problem, @prksu !
LGTM.
Merging after tests pass.
Codecov Report
@@ Coverage Diff @@
## master #2818 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 136 136
Lines 12263 12263
=======================================
Hits 12025 12025
Misses 162 162
Partials 76 76
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide full response for generate-jitconfig method instead of
encoded_jit_configonly. According to the doc there is arunnerobject in the API response.why do we need it? since the generate-jitconfig API is just not generating jitconfig but also creating new self-hosted runner to the github so there is no way we can get the newly created runner id other than from this response.
cc @mkulke @gmlewis