Initial implementation of codespaces API by aidandj · Pull Request #2803 · google/go-github

aidandj · 2023-06-09T16:20:30Z

google-cla · 2023-06-09T16:20:34Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Signed-off-by: Aidan Jensen <aidan@artificial.com>

gmlewis

Nice job, @artificial-aidan!
Just a few changes please, and then we will be ready for a second LGTM+Approval before merging.

github/codespaces.go

github/codespaces_test.go

github/codespaces.go

gmlewis · 2023-06-09T16:37:30Z

github/codespaces.go

+	StorageInBytes       *int    `json:"storage_in_bytes,omitempty"`
+	MemoryInBytes        *int    `json:"memory_in_bytes,omitempty"`


Suggested change

StorageInBytes *int `json:"storage_in_bytes,omitempty"`

MemoryInBytes *int `json:"memory_in_bytes,omitempty"`

StorageInBytes *int64 `json:"storage_in_bytes,omitempty"`

MemoryInBytes *int64 `json:"memory_in_bytes,omitempty"`

github/codespaces.go

aidandj · 2023-06-09T17:09:52Z

Nice job, @artificial-aidan! Just a few changes please, and then we will be ready for a second LGTM+Approval before merging.

I'll push those up. I also renamed some of the list methods to match others in the repo.

gmlewis · 2023-06-09T17:14:29Z

Thank you!
Please run "go generate ./..." in the top of the repo and push (not force-push) the changes to the PR. (...and also run gofmt, of course.)
Also, please remember to sign the CLA.
See CONTRIBUTING.md for more details.

aidandj · 2023-06-09T17:19:15Z

Thank you! Please run "go generate ./..." in the top of the repo and push (not force-push) the changes to the PR. (...and also run gofmt, of course.) Also, please remember to sign the CLA. See CONTRIBUTING.md for more details.

Working on the CLA now.

Should I push the suggested changes, then run go generate?

Signed-off-by: Aidan Jensen <aidan@artificial.com>

codecov · 2023-06-09T18:10:56Z

Codecov Report

Merging #2803 (bbc2995) into master (3efdd2c) will decrease coverage by 0.06%.
The diff coverage is 95.47%.

@@            Coverage Diff             @@
##           master    #2803      +/-   ##
==========================================
- Coverage   98.06%   98.00%   -0.06%     
==========================================
  Files         132      134       +2     
  Lines       11650    11915     +265     
==========================================
+ Hits        11424    11677     +253     
- Misses        154      162       +8     
- Partials       72       76       +4

Impacted Files	Coverage Δ
github/messages.go	`100.00% <ø> (ø)`
github/codespaces.go	`92.40% <92.40%> (ø)`
github/codespaces_secrets.go	`96.72% <96.72%> (ø)`
github/event.go	`100.00% <100.00%> (ø)`
github/github.go	`97.97% <100.00%> (+<0.01%)`	⬆️

Signed-off-by: Aidan Jensen <aidan@artificial.com>

aidandj · 2023-06-09T20:09:24Z

The last commit basically mirrors the functionality and layout of Action secrets, but consolidated the tests a bit. I added some examples I used when validating its functionality against a real github.

gmlewis · 2023-06-09T20:16:17Z

Please don't use force-push in this repo, as we always squash-and-merge at the end anyway.
It makes reviews on GitHub particularly painful to see what changed since the last review.
See CONTRIBUTING.md for more details.

aidandj · 2023-06-09T20:17:38Z

Please don't use force-push in this repo, as we always squash-and-merge at the end anyway. It makes reviews on GitHub particularly painful to see what changed since the last review. See CONTRIBUTING.md for more details.

Sorry about that. Must have been out of habit 👍

example/codespaces/newreposecretwithxcrypto/main.go

example/codespaces/newusersecretwithxcrypto/main.go

github/codespaces.go

Signed-off-by: Aidan Jensen <aidan@artificial.com>

gmlewis

Thank you, @artificial-aidan !
LGTM.

Awaiting CLA and LGTM+Approval from any other contributor to this repo before merging.

gmlewis · 2023-06-09T21:22:16Z

It looks like you might need to run gofmt and go generate ./... again.

Signed-off-by: Aidan Jensen <aidan@artificial.com>

aidandj · 2023-06-15T01:12:47Z

@gmlewis got the CLA signed

gmlewis

Thank you, @artificial-aidan !
LGTM.

Awaiting LGTM+Approval from any other contributor to this repo before merging.

gmlewis · 2023-06-19T12:04:09Z

Thank you, @valbeat !
Merging.

Initial implementation of codespaces API

6b80e61

Signed-off-by: Aidan Jensen <aidan@artificial.com>

gmlewis requested changes Jun 9, 2023

View reviewed changes

gmlewis added the NeedsReview PR is awaiting a review before merging. label Jun 9, 2023

Address PR comments

775679f

Signed-off-by: Aidan Jensen <aidan@artificial.com>

aidandj force-pushed the aidan/codespaces branch from e569e7b to 775679f Compare June 9, 2023 17:20

aidandj added 3 commits June 9, 2023 10:23

Additional PR feedback

195e240

Signed-off-by: Aidan Jensen <aidan@artificial.com>

Fix missed test

14112bf

Signed-off-by: Aidan Jensen <aidan@artificial.com>

go generate output

50a056c

Signed-off-by: Aidan Jensen <aidan@artificial.com>

aidandj added 2 commits June 9, 2023 13:07

"Add codespace secret management"

d5ae9cc

Signed-off-by: Aidan Jensen <aidan@artificial.com>

Update copyright notice for examples

1c07b22

Signed-off-by: Aidan Jensen <aidan@artificial.com>

gmlewis requested changes Jun 9, 2023

View reviewed changes

aidandj added 2 commits June 9, 2023 14:05

Fix Geo/Location deprecation

276655a

Signed-off-by: Aidan Jensen <aidan@artificial.com>

Example typos and doc fixes

67be158

Signed-off-by: Aidan Jensen <aidan@artificial.com>

gmlewis approved these changes Jun 9, 2023

View reviewed changes

Fix fallout from location/geo swap

bbc2995

Signed-off-by: Aidan Jensen <aidan@artificial.com>

gmlewis approved these changes Jun 15, 2023

View reviewed changes

valbeat approved these changes Jun 19, 2023

View reviewed changes

gmlewis merged commit 56c2c3b into google:master Jun 19, 2023

gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jun 19, 2023

KenSpur mentioned this pull request Jun 19, 2023

[MAINT]: go-github client v53.2.0 integrations/terraform-provider-github#1742

Closed

1 task

gmlewis mentioned this pull request Nov 24, 2023

Various Codespace Secrets endpoints failing when using a Personal Access Token or GitHub App #3000

Open

		StorageInBytes *int `json:"storage_in_bytes,omitempty"`
		MemoryInBytes *int `json:"memory_in_bytes,omitempty"`

Conversation

aidandj commented Jun 9, 2023

Uh oh!

google-cla bot commented Jun 9, 2023

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmlewis Jun 9, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aidandj commented Jun 9, 2023

Uh oh!

gmlewis commented Jun 9, 2023

Uh oh!

aidandj commented Jun 9, 2023

Uh oh!

codecov bot commented Jun 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aidandj commented Jun 9, 2023

Uh oh!

gmlewis commented Jun 9, 2023

Uh oh!

aidandj commented Jun 9, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

gmlewis commented Jun 9, 2023

Uh oh!

aidandj commented Jun 15, 2023

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

gmlewis commented Jun 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jun 9, 2023 •

edited

Loading