Skip to content

Add generate-jitconfig API for self-hosted runners#2801

Merged
gmlewis merged 8 commits intogoogle:masterfrom
mkulke:mkulke/generate-runner-jit-config
Jun 19, 2023
Merged

Add generate-jitconfig API for self-hosted runners#2801
gmlewis merged 8 commits intogoogle:masterfrom
mkulke:mkulke/generate-runner-jit-config

Conversation

@mkulke
Copy link
Copy Markdown
Contributor

@mkulke mkulke commented Jun 7, 2023

GitHub recently introduced just-in-time configuration for self-hosted runner, so runners do not need to be seeded with privileged tokens. This PR adds those endpoints for orgs + repos.

mkulke added 2 commits June 7, 2023 12:06
@mkulke
Add generate-jitconfig API for self-hosted runners
ec71de4 
Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke
Added generated files
9162f75 
Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
gmlewis
gmlewis requested changes Jun 7, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mkulke.

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Jun 7, 2023

Please remember to run go generate ./... at the top-level of the repo and push (not force-push) the changes to this PR.
See CONTRIBUTING.md for more details.

mkulke and others added 3 commits June 7, 2023 14:29
@mkulke @gmlewis
Update github/actions_runners.go
2279db6 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@mkulke @gmlewis
Update github/actions_runners.go
8cdabba 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@mkulke
Addressed review comments
32e1b36 
Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke mkulke requested a review from gmlewis June 7, 2023 12:39
gmlewis
gmlewis reviewed Jun 7, 2023
View reviewed changes
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jun 7, 2023
@gabriel-samfira
Copy link
Copy Markdown
Contributor

gabriel-samfira commented Jun 7, 2023

Hi @mkulke !

I know the docs don't mention enterprises (although the blog seems to). I would be surprised if this was missing for enterprises/%v/actions/runners/generate-jitconfig.

I think I can ask someone to test this out. But I think that can be added as a separate PR. I don't want to block this one 😄.

mkulke added 2 commits June 8, 2023 08:18
@mkulke
Addressed review comments
1e69ccf 
Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke
Codegen
9ed9008 
Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke mkulke requested a review from gmlewis June 8, 2023 06:19
@mkulke
Copy link
Copy Markdown
Contributor Author

mkulke commented Jun 8, 2023

Hi @mkulke !

I know the docs don't mention enterprises (although the blog seems to). I would be surprised if this was missing for enterprises/%v/actions/runners/generate-jitconfig.

I think I can ask someone to test this out. But I think that can be added as a separate PR. I don't want to block this one 😄.

yeah, I was also wondering about that and opted to limit it to what's documented atm.

@gabriel-samfira
Copy link
Copy Markdown
Contributor

gabriel-samfira commented Jun 8, 2023

yeah, I was also wondering about that and opted to limit it to what's documented atm.

Thanks for adding this!

gmlewis
gmlewis reviewed Jun 8, 2023
View reviewed changes
@mkulke
Renamed config struct
82526e3 
Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke mkulke requested a review from gmlewis June 8, 2023 14:12
gmlewis
gmlewis approved these changes Jun 8, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mkulke !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 8, 2023

Codecov Report

Merging #2801 (82526e3) into master (3efdd2c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2801   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         132      132           
  Lines       11650    11676   +26     
=======================================
+ Hits        11424    11450   +26     
  Misses        154      154           
  Partials       72       72
Impacted Files Coverage Δ
github/messages.go 100.00% <ø> (ø)
github/actions_runners.go 100.00% <100.00%> (ø)
github/event.go 100.00% <100.00%> (ø)

valbeat
valbeat approved these changes Jun 19, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Jun 19, 2023

Thank you, @valbeat !
Merging.

@gmlewis gmlewis merged commit 4f74d0c into google:master Jun 19, 2023
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

+1 more reviewer

@valbeat valbeat valbeat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mkulke @gmlewis @gabriel-samfira @valbeat