Remove GenerateReleaseNotes from RepositoriesService.EditRelease#2445
Merged
gmlewis merged 1 commit intogoogle:masterfrom Sep 5, 2022
coro:remove-generate-release-notes-on-edit
Merged
Remove GenerateReleaseNotes from RepositoriesService.EditRelease#2445gmlewis merged 1 commit intogoogle:masterfrom coro:remove-generate-release-notes-on-edit
gmlewis merged 1 commit intogoogle:masterfrom
coro:remove-generate-release-notes-on-edit
Conversation
According to the [GitHub v3 API reference](https://docs.github.com/en/rest/releases/releases#update-a-release), `generate_release_notes` is not a recognised body parameter of the endpoint to update a release. If provided to the API, it will have no effect. This commit removes the setting of this parameter when updating a release, to avoid confusion in the effect of setting this parameter.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
@@ Coverage Diff @@
## master #2445 +/- ##
==========================================
- Coverage 98.03% 98.03% -0.01%
==========================================
Files 122 122
Lines 10690 10689 -1
==========================================
- Hits 10480 10479 -1
Misses 144 144
Partials 66 66
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
|
Thank you, @raynigon ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #2444
According to the GitHub v3 API reference,
generate_release_notesis not a recognised body parameter of the endpoint to update a release. If provided tothe API, it will have no effect.
This commit removes the setting of this parameter when updating a release, to avoid confusion in the effect of
setting this parameter.