Remove omitempty from Content field of RepositoryContentFileOptions#2430
Merged
gmlewis merged 1 commit intogoogle:masterfrom Aug 2, 2022
Ashvin-Ranjan:fix_repo_content
Merged
Remove omitempty from Content field of RepositoryContentFileOptions#2430gmlewis merged 1 commit intogoogle:masterfrom Ashvin-Ranjan:fix_repo_content
gmlewis merged 1 commit intogoogle:masterfrom
Ashvin-Ranjan:fix_repo_content
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
@@ Coverage Diff @@
## master #2430 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 120 120
Lines 10558 10558
=======================================
Hits 10354 10354
Misses 140 140
Partials 64 64
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gmlewis
approved these changes
Aug 2, 2022
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @Ashvin-Ranjan !
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2427
This removes
omitemptyfromRepositoryContentFileOptions.Contentso that an emptycontentfield can be passed in to generate empty files. Before, thecontentfield was omitted, which caused the GitHub API to not accept the request as the field is required, even if it is empty.