Add security-advisory and code-scanning-alert event types#2311
Add security-advisory and code-scanning-alert event types#2311gmlewis merged 5 commits intogoogle:masterfrom
Conversation
… added Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
|
ping reviewer |
Codecov Report
@@ Coverage Diff @@
## master #2311 +/- ##
=======================================
Coverage 97.84% 97.84%
=======================================
Files 115 115
Lines 10403 10415 +12
=======================================
+ Hits 10179 10191 +12
Misses 156 156
Partials 68 68
Continue to review full report at Codecov.
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @sourikghosh !
Just a few minor changes, please, then we will need a second LGTM from any other contributor to this repo before merging.
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
gmlewis
left a comment
There was a problem hiding this comment.
This is looking great, @sourikghosh !
Just a couple minor tweaks, please, then we should be ready for another LGTM and merging.
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @sourikghosh !
LGTM.
Awaiting second LGTM from any other contributor to this repo before merging.
|
could any of you please review this PR |
raynigon
left a comment
There was a problem hiding this comment.
I think it would be nice to have the link to the github docs in the comment.
Besides that, LGTM
Co-authored-by: Simon Schneider <10846939+raynigon@users.noreply.github.com>
|
Thank you, @raynigon ! |
Signed-off-by: Sourik Ghosh sourikghosh31@gmail.com
fixes #2306
What does this PR do ?
security-advisory event type with unit test added
code-scanning-alert event type with unit test added