Fix branch protection request fields (#2977)

viqueen · web-flow · commit f643c0f3fab9 · 2023-11-03T11:07:43.000-04:00
Fixes: #2976.
diff --git a/github/repos.go b/github/repos.go
@@ -1097,7 +1097,7 @@ type RequiredStatusChecks struct {
 	Contexts []string `json:"contexts,omitempty"`
 	// The list of status checks to require in order to merge into this
 	// branch.
-	Checks      []*RequiredStatusCheck `json:"checks"`
+	Checks      []*RequiredStatusCheck `json:"checks,omitempty"`
 	ContextsURL *string                `json:"contexts_url,omitempty"`
 	URL         *string                `json:"url,omitempty"`
 }
diff --git a/github/repos_test.go b/github/repos_test.go
@@ -1766,7 +1766,6 @@ func TestRepositoriesService_UpdateBranchProtection_StrictNoChecks(t *testing.T)
 			input := &ProtectionRequest{
 				RequiredStatusChecks: &RequiredStatusChecks{
 					Strict: true,
-					Checks: []*RequiredStatusCheck{},
 				},
 				RequiredPullRequestReviews: &PullRequestReviewsEnforcementRequest{
 					DismissStaleReviews: true,
@@ -1802,8 +1801,7 @@ func TestRepositoriesService_UpdateBranchProtection_StrictNoChecks(t *testing.T)
 				fmt.Fprintf(w, `{
 					"required_status_checks":{
 						"strict":true,
-						"contexts":[],
-						"checks": []
+						"contexts":[]
 					},
 					"required_pull_request_reviews":{
 						"dismissal_restrictions":{
@@ -1847,7 +1845,6 @@ func TestRepositoriesService_UpdateBranchProtection_StrictNoChecks(t *testing.T)
 				RequiredStatusChecks: &RequiredStatusChecks{
 					Strict:   true,
 					Contexts: []string{},
-					Checks:   []*RequiredStatusCheck{},
 				},
 				RequiredPullRequestReviews: &PullRequestReviewsEnforcement{
 					DismissStaleReviews: true,

Original file line number	Diff line number	Diff line change
`@@ -1097,7 +1097,7 @@ type RequiredStatusChecks struct {`
`1097`	`1097`	Contexts []string `json:"contexts,omitempty"`
`1098`	`1098`	`// The list of status checks to require in order to merge into this`
`1099`	`1099`	`// branch.`
`1100`		- Checks []*RequiredStatusCheck `json:"checks"`
	`1100`	+ Checks []*RequiredStatusCheck `json:"checks,omitempty"`
`1101`	`1101`	ContextsURL *string `json:"contexts_url,omitempty"`
`1102`	`1102`	URL *string `json:"url,omitempty"`
`1103`	`1103`	`}`