Changed ReviewPersonalAccessTokenRequest function signature for type safety

joaopenteado · joaopenteado · commit c5f2b2744d43 · 2023-07-07T17:49:05.000+09:00
diff --git a/github/orgs_personal_access_tokens.go b/github/orgs_personal_access_tokens.go
@@ -22,7 +22,7 @@ type ReviewPersonalAccessTokenRequestOptions struct {
 // `action` can be one of `approve` or `deny`.
 //
 // GitHub API docs: https://docs.github.com/en/rest/orgs/personal-access-tokens?apiVersion=2022-11-28#review-a-request-to-access-organization-resources-with-a-fine-grained-personal-access-token
-func (s *OrganizationsService) ReviewPersonalAccessTokenRequest(ctx context.Context, org, requestID string, opts ReviewPersonalAccessTokenRequestOptions) (*Response, error) {
+func (s *OrganizationsService) ReviewPersonalAccessTokenRequest(ctx context.Context, org string, requestID int64, opts ReviewPersonalAccessTokenRequestOptions) (*Response, error) {
 	u := fmt.Sprintf("orgs/%v/personal-access-token-requests/%v", org, requestID)
 
 	req, err := s.client.NewRequest(http.MethodPost, u, &opts)
diff --git a/github/orgs_personal_access_tokens_test.go b/github/orgs_personal_access_tokens_test.go
@@ -23,7 +23,7 @@ func TestOrganizationsService_ReviewPersonalAccessTokenRequest(t *testing.T) {
 		Reason: String("r"),
 	}
 
-	mux.HandleFunc("/orgs/o/personal-access-token-requests/r", func(w http.ResponseWriter, r *http.Request) {
+	mux.HandleFunc("/orgs/o/personal-access-token-requests/1", func(w http.ResponseWriter, r *http.Request) {
 		v := new(ReviewPersonalAccessTokenRequestOptions)
 		json.NewDecoder(r.Body).Decode(v)
 
@@ -36,7 +36,7 @@ func TestOrganizationsService_ReviewPersonalAccessTokenRequest(t *testing.T) {
 	})
 
 	ctx := context.Background()
-	res, err := client.Organizations.ReviewPersonalAccessTokenRequest(ctx, "o", "r", input)
+	res, err := client.Organizations.ReviewPersonalAccessTokenRequest(ctx, "o", 1, input)
 	if err != nil {
 		t.Errorf("Organizations.ReviewPersonalAccessTokenRequest returned error: %v", err)
 	}
@@ -47,12 +47,12 @@ func TestOrganizationsService_ReviewPersonalAccessTokenRequest(t *testing.T) {
 
 	const methodName = "ReviewPersonalAccessTokenRequest"
 	testBadOptions(t, methodName, func() (err error) {
-		_, err = client.Organizations.ReviewPersonalAccessTokenRequest(ctx, "\n", "", input)
+		_, err = client.Organizations.ReviewPersonalAccessTokenRequest(ctx, "\n", 0, input)
 		return err
 	})
 
 	testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
-		return client.Organizations.ReviewPersonalAccessTokenRequest(ctx, "o", "r", input)
+		return client.Organizations.ReviewPersonalAccessTokenRequest(ctx, "o", 1, input)
 	})
 }
 
