Add explicit error return (#2469)

mo1ein · web-flow · commit 30d14315cf48 · 2022-09-17T14:41:32.000-04:00
diff --git a/github/repos_contents.go b/github/repos_contents.go
@@ -317,5 +317,9 @@ func (s *RepositoriesService) GetArchiveLink(ctx context.Context, owner, repo st
 	}
 
 	parsedURL, err := url.Parse(resp.Header.Get("Location"))
-	return parsedURL, newResponse(resp), err
+	if err != nil {
+		return nil, newResponse(resp), err
+	}
+
+	return parsedURL, newResponse(resp), nil
 }
diff --git a/github/repos_contents_test.go b/github/repos_contents_test.go
@@ -744,6 +744,23 @@ func TestRepositoriesService_GetArchiveLink_StatusMovedPermanently_followRedirec
 	}
 }
 
+func TestRepositoriesService_GetArchiveLink_invalidLocationHeader(t *testing.T) {
+	client, mux, _, teardown := setup()
+	defer teardown()
+
+	mux.HandleFunc("/repos/o/r/tarball", func(w http.ResponseWriter, r *http.Request) {
+		testMethod(t, r, "GET")
+		ctlChar := 0x7f
+		badURL := "https://google.com" + string(byte(ctlChar))
+		w.Header().Add("Location", badURL)
+		w.WriteHeader(http.StatusFound)
+	})
+
+	ctx := context.Background()
+	_, _, err := client.Repositories.GetArchiveLink(ctx, "o", "r", Tarball, &RepositoryContentGetOptions{}, false)
+	testURLParseError(t, err)
+}
+
 func TestRepositoriesService_GetContents_NoTrailingSlashInDirectoryApiPath(t *testing.T) {
 	client, mux, _, teardown := setup()
 	defer teardown()

Original file line number	Diff line number	Diff line change
`@@ -317,5 +317,9 @@ func (s *RepositoriesService) GetArchiveLink(ctx context.Context, owner, repo st`
`317`	`317`	`}`
`318`	`318`
`319`	`319`	`parsedURL, err := url.Parse(resp.Header.Get("Location"))`
`320`		`- return parsedURL, newResponse(resp), err`
	`320`	`+ if err != nil {`
	`321`	`+ return nil, newResponse(resp), err`
	`322`	`+ }`
	`323`	`+`
	`324`	`+ return parsedURL, newResponse(resp), nil`
`321`	`325`	`}`