go.mod: do not make a viral minimum go version#2237
Conversation
`go` version is the minimum possible go version that you can compile the package with. This is viral; all importers inherint the version. This package does NOT need 1.25.7 to build, and should not require such a version.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #2237 +/- ##
===========================================
- Coverage 71.67% 52.74% -18.94%
===========================================
Files 123 164 +41
Lines 9935 11113 +1178
===========================================
- Hits 7121 5861 -1260
- Misses 2115 4546 +2431
- Partials 699 706 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey, thanks for this. I missed the comment on the other commit, too. I wasn't aware of how golang did dependency resolution. Is there a reason specifying "1.25.0" is better than "1.25" in this case? The presubmit is hitched on the other go.mod files having a later version. Changing those to match the root go.mod should fix this. |
ref: https://go.googlesource.com/proposal/+/HEAD/design/69095-x-repo-continuous-go.md#why-1_n_1_0 |
|
Ah, thanks! I went hunting "which module was responsible this this time?" but found it was already fixed (but not yet released). |
|
I just noticed that GitHub actions was configured to use Opened a pull-request to fix that; |
goversion is the minimum possible go version that you can compile the package with. This is viral; all importers inherint the version.This package does NOT need 1.25.7 to build, and should not require such a version.
also noted here #2211 (comment)