Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1684 +/- ##
==========================================
+ Coverage 72.81% 72.84% +0.03%
==========================================
Files 121 121
Lines 9633 9629 -4
==========================================
Hits 7014 7014
+ Misses 1941 1939 -2
+ Partials 678 676 -2
|
imjasonh
approved these changes
May 1, 2023
Contributor
imjasonh
left a comment
There was a problem hiding this comment.
LGTM, feel free to ignore these nits.
| } | ||
|
|
||
| func (k *fakeKeychain) Resolve(target Resource) (Authenticator, error) { | ||
| func (k *fakeKeychain) Resolve(_ Resource) (Authenticator, error) { |
Contributor
There was a problem hiding this comment.
Suggested change
| func (k *fakeKeychain) Resolve(_ Resource) (Authenticator, error) { | |
| func (k *fakeKeychain) Resolve(Resource) (Authenticator, error) { |
| } | ||
|
|
||
| func (m *MockClient) NegotiateAPIVersion(ctx context.Context) { | ||
| func (m *MockClient) NegotiateAPIVersion(_ context.Context) { |
Contributor
There was a problem hiding this comment.
Suggested change
| func (m *MockClient) NegotiateAPIVersion(_ context.Context) { | |
| func (m *MockClient) NegotiateAPIVersion(context.Context) { |
| } | ||
|
|
||
| func (r *errReader) Read(p []byte) (int, error) { | ||
| func (r *errReader) Read(_ []byte) (int, error) { |
Contributor
There was a problem hiding this comment.
Suggested change
| func (r *errReader) Read(_ []byte) (int, error) { | |
| func (r *errReader) Read([]byte) (int, error) { |
| } | ||
|
|
||
| func (e *errReadCloser) Read(p []byte) (int, error) { | ||
| func (e *errReadCloser) Read(_ []byte) (int, error) { |
Contributor
There was a problem hiding this comment.
Suggested change
| func (e *errReadCloser) Read(_ []byte) (int, error) { | |
| func (e *errReadCloser) Read([]byte) (int, error) { |
| } | ||
|
|
||
| func (t *mockTransport) RoundTrip(in *http.Request) (out *http.Response, err error) { | ||
| func (t *mockTransport) RoundTrip(_ *http.Request) (out *http.Response, err error) { |
Contributor
There was a problem hiding this comment.
Suggested change
| func (t *mockTransport) RoundTrip(_ *http.Request) (out *http.Response, err error) { | |
| func (t *mockTransport) RoundTrip(*http.Request) (out *http.Response, err error) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.