fix: remove current time from random.Image history#1678
Merged
jonjohnsonjr merged 1 commit intogoogle:mainfrom Apr 27, 2023
Merged
fix: remove current time from random.Image history#1678jonjohnsonjr merged 1 commit intogoogle:mainfrom
jonjohnsonjr merged 1 commit intogoogle:mainfrom
Conversation
This makes the images non-reproducible which defeats the purpose of setting the random source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The history contained the
time.Now()which I missed in my prior PR #1675 . Using the current time makes the random images non-reproducible which defeats the purpose of setting the random source. I removed the CreatedBy time since it is optional according to the OCI spec. We could instead use the random source to generate a random time but the time is not used for anything important so I do not see the value in doing that.I added tests that revealed the issue then fixed the issue.
Related to #1674