Skip to content

Replace deprecated command with environment file#1667

Merged
imjasonh merged 1 commit intogoogle:mainfrom
jongwooo:chore/replace-deprecated-command-with-environment-file
Apr 23, 2023
Merged

Replace deprecated command with environment file#1667
imjasonh merged 1 commit intogoogle:mainfrom
jongwooo:chore/replace-deprecated-command-with-environment-file

Conversation

@jongwooo
Copy link
Copy Markdown
Contributor

Description

Resolve #1666

Update .github/workflows/release.yml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

echo "::set-output name=hashes::$(cat $checksum_file | base64 -w0)"

TO-BE

echo "hashes=$(cat $checksum_file | base64 -w0)" >> $GITHUB_OUTPUT

Copy link
Copy Markdown
Contributor

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@imjasonh imjasonh enabled auto-merge (squash) April 23, 2023 02:15
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #1667 (12769c7) into main (07c767c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1667   +/-   ##
=======================================
  Coverage   71.89%   71.89%           
=======================================
  Files         120      120           
  Lines        9833     9833           
=======================================
  Hits         7069     7069           
  Misses       2046     2046           
  Partials      718      718           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imjasonh imjasonh merged commit ad695c0 into google:main Apr 23, 2023
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch April 23, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file

3 participants