Skip to content

Change return type of remote.Referrers#1652

Merged
jonjohnsonjr merged 2 commits intogoogle:mainfrom
jonjohnsonjr:referrers
Apr 17, 2023
Merged

Change return type of remote.Referrers#1652
jonjohnsonjr merged 2 commits intogoogle:mainfrom
jonjohnsonjr:referrers

Conversation

@jonjohnsonjr
Copy link
Copy Markdown
Collaborator

Actually using this was cumbersome because it just returns a struct. This is a breaking change, but I don't think it's a huge deal because not too many people should be using this yet (and we're < 1.0.0).

Actually using this was cumbersome because it just returns a struct.
This is a breaking change, but I don't think it's a huge deal because
not too many people should be using this yet (and we're < 1.0.0).
@jonjohnsonjr
Copy link
Copy Markdown
Collaborator Author

cc @jdolitsky

@imjasonh
Copy link
Copy Markdown
Contributor

What methods did you find yourself needing from the interface that you didn't get from the struct?

@jonjohnsonjr
Copy link
Copy Markdown
Collaborator Author

What methods did you find yourself needing from the interface that you didn't get from the struct?

E.g. if I want to save referrers to an OCI layout, I can just do that with a v1.ImageIndex. Currently, I have to iterate over each entry and have a separate remote.Get call for each one.

@imjasonh
Copy link
Copy Markdown
Contributor

Makes sense, thanks for that example.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 17, 2023

Codecov Report

Merging #1652 (727d959) into main (bc990d6) will decrease coverage by 0.09%.
The diff coverage is 82.85%.

@@            Coverage Diff             @@
##             main    #1652      +/-   ##
==========================================
- Coverage   72.19%   72.11%   -0.09%     
==========================================
  Files         120      120              
  Lines        9771     9782      +11     
==========================================
  Hits         7054     7054              
- Misses       2002     2009       +7     
- Partials      715      719       +4     
Impacted Files Coverage Δ
pkg/v1/remote/descriptor.go 74.65% <81.81%> (-0.70%) ⬇️
pkg/v1/empty/index.go 100.00% <100.00%> (ø)
pkg/v1/remote/referrers.go 40.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Contributor

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotta make sure to update in cosign! I can do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants