gcrane: Use page size of 10,000 for googley things#1645
Merged
jonjohnsonjr merged 1 commit intogoogle:mainfrom Apr 18, 2023
Merged
Conversation
We dropped down to 1000 for the sake of ECR, but that doesn't make much sense, really. Per https://cloud.google.com/artifact-registry/quotas#limits this will return up to 10k items.
Codecov Report
@@ Coverage Diff @@
## main #1645 +/- ##
==========================================
- Coverage 72.07% 72.05% -0.02%
==========================================
Files 120 120
Lines 9772 9776 +4
==========================================
+ Hits 7043 7044 +1
- Misses 2010 2012 +2
- Partials 719 720 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
|
Why is |
imjasonh
approved these changes
Apr 18, 2023
Contributor
|
Found #984 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We dropped down to 1000 for the sake of ECR, but that doesn't make much sense, really.
Per https://cloud.google.com/artifact-registry/quotas#limits this will return up to 10k items.
Fixes #1643