Allow remote config layers to be lazy fetched#1634
Merged
jonjohnsonjr merged 1 commit intogoogle:mainfrom Apr 6, 2023
Merged
Conversation
The partial.ConfigLayer implementation needs to fetch the config blob, but we don't always need to do that (e.g. if we just need the digest).
Codecov Report
@@ Coverage Diff @@
## main #1634 +/- ##
==========================================
- Coverage 72.30% 72.28% -0.03%
==========================================
Files 119 119
Lines 9566 9578 +12
==========================================
+ Hits 6917 6923 +6
- Misses 1943 1947 +4
- Partials 706 708 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
imjasonh
approved these changes
Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The partial.ConfigLayer implementation needs to fetch the config blob, but we don't always need to do that (e.g. if we just need the digest).