retry HTTP 499 errors by default#1612
Merged
imjasonh merged 1 commit intogoogle:mainfrom Mar 23, 2023
Merged
Conversation
jonjohnsonjr
approved these changes
Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP 499 is a status code that nginx made up to indicate the client hung up before the server responded. See https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#nginx
We're seeing this response relatively often coming from blob requests to Cloudflare R2, and retrying in general seems to work just fine.
If a 499 is encountered multiple times, the overall blob request will still fail, so a persistent 499 issue should be surfaced to the user after a brief delay, just like with 502, etc.
Since it's unofficial there's no Go const for 499. See https://pkg.go.dev/net/http#pkg-constants