Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1589 +/- ##
==========================================
+ Coverage 72.88% 72.91% +0.03%
==========================================
Files 118 118
Lines 9422 9422
==========================================
+ Hits 6867 6870 +3
+ Misses 1861 1859 -2
+ Partials 694 693 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
Some things I've learned about the
I think I'd like to fix both of those for |
jonjohnsonjr
approved these changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1587
NB: This doesn't clear creds from Podman-configured auth, which
authn.DefaultKeychainuses if a Docker config file isn't found. This might be confusing, butcrane auth logindoesn't use that either, so 🤷.It might make more sense to always
loginusingDOCKER_CONFIGandlogoutof Docker- or Podman-configured auth, feedback welcome.