Skip to content

crane: add crane registry serve subcommand#1586

Merged
imjasonh merged 7 commits intogoogle:mainfrom
imjasonh:crane-serve-2
Mar 9, 2023
Merged

crane: add crane registry serve subcommand#1586
imjasonh merged 7 commits intogoogle:mainfrom
imjasonh:crane-serve-2

Conversation

@imjasonh
Copy link
Copy Markdown
Contributor

@imjasonh imjasonh commented Mar 6, 2023

Fixes #1579

Previously, #1211, which was shelved until we had an on-disk implementation, which never materialized. If/when that comes along we can support a persistent crane serve.

@imjasonh imjasonh requested a review from jonjohnsonjr March 6, 2023 14:34
@imjasonh imjasonh enabled auto-merge (squash) March 6, 2023 14:34
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 6, 2023 •
edited
Loading

Codecov Report

Merging #1586 (c5a2e00) into main (6770304) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head c5a2e00 differs from pull request most recent head 9af0699. Consider uploading reports for the commit 9af0699 to get more accurate results

@@            Coverage Diff             @@
##             main    #1586      +/-   ##
==========================================
+ Coverage   72.88%   72.91%   +0.03%     
==========================================
  Files         118      118              
  Lines        9422     9422              
==========================================
+ Hits         6867     6870       +3     
+ Misses       1861     1859       -2     
+ Partials      694      693       -1
Impacted Files Coverage Δ
pkg/v1/random/image.go 78.57% <100.00%> (ø)
pkg/v1/remote/write.go 62.84% <0.00%> (+0.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

thesayyn
thesayyn reviewed Mar 7, 2023
View reviewed changes
thesayyn
thesayyn reviewed Mar 7, 2023
View reviewed changes
thesayyn
thesayyn approved these changes Mar 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@thesayyn
Copy link
Copy Markdown
Contributor

thesayyn commented Mar 8, 2023

just a thought; maybe crane registry serve is better than crane serve? I like the explicitness of the commands.

@imjasonh imjasonh changed the title crane: add serve subcommand crane: add crane registry serve subcommand Mar 9, 2023
@imjasonh
Copy link
Copy Markdown
Contributor Author

imjasonh commented Mar 9, 2023

just a thought; maybe crane registry serve is better than crane serve? I like the explicitness of the commands.

crane registry serve sgtm

@imjasonh imjasonh merged commit ff810c1 into google:main Mar 9, 2023
@thesayyn
Copy link
Copy Markdown
Contributor

thesayyn commented Mar 10, 2023

it looks like it's been a while since the latest release hehe. It may be a new release time already. 🫡

@imjasonh
Copy link
Copy Markdown
Contributor Author

imjasonh commented Mar 11, 2023

Yeah I can cut a release next week.

@seh seh mentioned this pull request Mar 13, 2023
Closed
@thesayyn
Copy link
Copy Markdown
Contributor

thesayyn commented Mar 14, 2023

Yeah I can cut a release next week.

awesome

@imjasonh
Copy link
Copy Markdown
Contributor Author

imjasonh commented Mar 15, 2023

Yeah I can cut a release next week.

awesome

Jon did it: https://github.com/google/go-containerregistry/releases/tag/v0.14.0

@thesayyn
Copy link
Copy Markdown
Contributor

thesayyn commented Mar 15, 2023

You guys are awesome

@vbatts
Copy link
Copy Markdown

vbatts commented Mar 17, 2023

cool cool

@thesayyn thesayyn mentioned this pull request Apr 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonjohnsonjr jonjohnsonjr jonjohnsonjr approved these changes

+2 more reviewers

@alexeagle alexeagle alexeagle left review comments

@thesayyn thesayyn thesayyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FR: implement crane serve

6 participants

@imjasonh @codecov-commenter @thesayyn @vbatts @alexeagle @jonjohnsonjr