Avoid v1.Manifest in crane edit config#1583
Merged
jonjohnsonjr merged 1 commit intogoogle:mainfrom Mar 15, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1583 +/- ##
==========================================
- Coverage 72.88% 72.84% -0.04%
==========================================
Files 118 118
Lines 9422 9435 +13
==========================================
+ Hits 6867 6873 +6
- Misses 1861 1865 +4
- Partials 694 697 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Mar 2, 2023
imjasonh
approved these changes
Mar 8, 2023
Because of how omitempty works, an empty Layers and a nil Layers will both be omitted. We don't want that, because different registries support different variants of that. Instead, we just pass through whatever was there before by treating the manifest as a map[string]any and manipulating that rather than using v1.Manifest-based helpers.
1d0747c to
4e72fe8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of how omitempty works, an empty Layers and a nil Layers will both be omitted. We don't want that, because different registries support different variants of that. Instead, we just pass through whatever was there before by treating the manifest as a map[string]any and manipulating that rather than using v1.Manifest-based helpers.