Set mediaType for empty.ImageIndex in RawManifest #1562
Merged
jonjohnsonjr merged 1 commit intogoogle:mainfrom Feb 9, 2023
Merged
Set mediaType for empty.ImageIndex in RawManifest #1562jonjohnsonjr merged 1 commit intogoogle:mainfrom
jonjohnsonjr merged 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Set previously unset mediaType for empty.ImageIndex so that the mediaType will be present in the raw manifest. empty.ImageIndex.MediaType() was unimpacted because it already returned OCIImageIndex directly.
0f66b4b to
99596cc
Compare
Codecov Report
@@ Coverage Diff @@
## main #1562 +/- ##
=======================================
Coverage 72.96% 72.97%
=======================================
Files 118 118
Lines 9419 9420 +1
=======================================
+ Hits 6873 6874 +1
Misses 1854 1854
Partials 692 692
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jonjohnsonjr
approved these changes
Feb 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set previously unset mediaType for empty.ImageIndex and update existing mediaType for empty.Image to OCIManifestSchema1