Support for OCI 1.1+ referrers via API#1546
Merged
jonjohnsonjr merged 7 commits intogoogle:mainfrom Feb 3, 2023
Merged
Conversation
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
d3bb955 to
224b9c7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1546 +/- ##
==========================================
- Coverage 73.07% 72.90% -0.18%
==========================================
Files 117 118 +1
Lines 9082 9364 +282
==========================================
+ Hits 6637 6827 +190
- Misses 1780 1845 +65
- Partials 665 692 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
imjasonh
reviewed
Feb 1, 2023
Contributor
imjasonh
left a comment
There was a problem hiding this comment.
Can we add support for referrers to pkg/registry, and use that to test this path?
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
jdolitsky
commented
Feb 2, 2023
Comment on lines
+112
to
+117
| // WithReferrersSupport enables the referrers API endpoint (OCI 1.1+) | ||
| func WithReferrersSupport(enabled bool) Option { | ||
| return func(r *registry) { | ||
| r.referrersEnabled = enabled | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
this is disabled by default, but we could go the other direction too
imjasonh
reviewed
Feb 3, 2023
Comment on lines
+585
to
+605
| // Check if the registry supports Referrers API. | ||
| // TODO: This should be done once per registry, not once per subject. | ||
| u := w.url(fmt.Sprintf("/v2/%s/referrers/%s", w.repo.RepositoryStr(), sub.DigestStr())) | ||
| req, err := http.NewRequest(http.MethodGet, u.String(), nil) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| req.Header.Set("Accept", string(types.OCIImageIndex)) | ||
| resp, err := w.client.Do(req.WithContext(ctx)) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| defer resp.Body.Close() | ||
|
|
||
| if err := transport.CheckError(resp, http.StatusOK, http.StatusNotFound, http.StatusBadRequest); err != nil { | ||
| return err | ||
| } | ||
| if resp.StatusCode == http.StatusOK { | ||
| // The registry supports Referrers API. The registry is responsible for updating the referrers list. | ||
| return nil | ||
| } |
Contributor
There was a problem hiding this comment.
Sounds like this will all go away once opencontainers/distribution-spec#379 is in, do we want to just start supporting that in here?
Contributor
Author
There was a problem hiding this comment.
i think id rather see it merged first, then come back to change here
imjasonh
approved these changes
Feb 3, 2023
Contributor
|
I'll let @jonjohnsonjr clickey the mergey |
jonjohnsonjr
approved these changes
Feb 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1543, use the referrers API endpoint if the registry supports it, otherwise fallback to digest tag