Allow crane edit to generate non-image artifacts#1545
Merged
imjasonh merged 1 commit intogoogle:mainfrom Jan 28, 2023
Merged
Conversation
imjasonh
reviewed
Jan 26, 2023
Contributor
imjasonh
left a comment
There was a problem hiding this comment.
I'm not super convinced we need to do more work to enable crane to produce invalid configs. Can this just live in a fork and not be supported behavior in crane?
Codecov Report
@@ Coverage Diff @@
## main #1545 +/- ##
==========================================
- Coverage 73.31% 73.29% -0.02%
==========================================
Files 117 117
Lines 9015 9032 +17
==========================================
+ Hits 6609 6620 +11
- Misses 1746 1750 +4
- Partials 660 662 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Instead of using mutate, just do this ourselves to allow for arbitrary config file contents rather than mutating the OCI config struct.
8b2fbca to
f8074a3
Compare
Collaborator
Author
|
I have re-framed the change in terms of more generic usefulness. |
imjasonh
approved these changes
Jan 28, 2023
Contributor
imjasonh
left a comment
There was a problem hiding this comment.
Now this I can get behind! 😍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using mutate, just do this ourselves to allow for arbitrary config file contents rather than mutating the OCI config struct.