Support artifactType, for images whose config.mediaType is not a config#1541
Merged
imjasonh merged 6 commits intogoogle:mainfrom Jan 27, 2023
Merged
Support artifactType, for images whose config.mediaType is not a config#1541imjasonh merged 6 commits intogoogle:mainfrom
imjasonh merged 6 commits intogoogle:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1541 +/- ##
==========================================
- Coverage 73.31% 73.09% -0.22%
==========================================
Files 117 117
Lines 9015 9065 +50
==========================================
+ Hits 6609 6626 +17
- Misses 1746 1776 +30
- Partials 660 663 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jonjohnsonjr
approved these changes
Jan 27, 2023
Collaborator
jonjohnsonjr
left a comment
There was a problem hiding this comment.
Overall LGTM. There are probably some things we missed, but let's let this bake for a bit before we cut a release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an index contains an image whose config.mediaType is not the normal config type (i.e., it's an artifact, packaged as an image for registry compatibility), the index's descriptor for the image will include
artifactType.This is work toward supporting the OCI 1.1 referrers fallback tag scheme, where referrers are managed by the client and pushed as indexes to the registry, tagged with
:sha256-abcdef....cc @jdolitsky