k8schain: Log and proceed if secret or SA are not found#1472
Merged
imjasonh merged 1 commit intogoogle:mainfrom Oct 23, 2022
Merged
k8schain: Log and proceed if secret or SA are not found#1472imjasonh merged 1 commit intogoogle:mainfrom
imjasonh merged 1 commit intogoogle:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1472 +/- ##
=======================================
Coverage 73.18% 73.18%
=======================================
Files 115 115
Lines 8809 8809
=======================================
Hits 6447 6447
Misses 1712 1712
Partials 650 650 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mattmoor
reviewed
Oct 22, 2022
mattmoor
approved these changes
Oct 22, 2022
Collaborator
mattmoor
left a comment
There was a problem hiding this comment.
Thanks, just one comment.
Contributor
Author
|
Good catch, done. |
b3f92f6 to
59d71d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1471